Comments on: Open Flash Chart Plugin for Ruby on Rails

By: Scott

Scott — Mon, 04 Feb 2008 21:09:00 +0000

Charlie This is great stuff. I tried to install your latest changes, but when I use the plugin script I just see the older release (no Line class in open_flash_chart.rb). Will you be committing your changes to SVN soon? Thanks, Scott

By: charlie

charlie — Mon, 04 Feb 2008 21:09:00 +0000

Scott – glad you like it. The changes should already be in SVN. I just checked – svn export http://svn.pullmonkey.com/plugins/trunk/open_flash_chart
;

By: charlie

charlie — Mon, 04 Feb 2008 21:09:00 +0000

Sorry, script/plugin install . What was it that you tried? Did you get any errors saying that the plugin already exists? Try moving the old version out of the way then plugin install it.

By: ilikerice

ilikerice — Mon, 04 Feb 2008 21:09:00 +0000

Hi, I’m wondering if it is possible to graph a trend line with missing values. For example, if I want to plot the value of something every 10 minutes for 6 hours, but a few of the timepoints are missing. Thanks!

By: charlie

charlie — Mon, 04 Feb 2008 21:09:00 +0000

@ilikerice – I think I understand what you are asking, but I am not sure. You have null values and probably a line graph and you want the line graph to contain null data but not to drop down to 0. If I understand you correctly you will want to check out this graph – http://pullmonkey.com/projects/open_flash_chart/view_source_code/null_data
You pretty much just put the string ‘null’ for your null data points and the swf object will pick it up. Note that there are points where data exists and no points where the data is null, but the line continues with the trend.

By: Slathered1

Slathered1 — Mon, 04 Feb 2008 21:09:00 +0000

Theres a bug in the pie gradient code. if !gradient @pie += ",#{!gradient}" end should be if !gradient @pie += ",#{gradient}" end or better yet, the method can just be defined as follows: def pie(alpha, line_color, style, gradient = true, border_size = false) @pie = "#{alpha},#{line_color},#{style},#{gradient}" @pie += ",#{border_size}" if border_size end

By: subaqua

subaqua — Mon, 04 Feb 2008 21:09:00 +0000

I'm confused. The code in subversion is way different than the code in the 1.9.7 release available on source forge (the 1.9.7 zip file). This is fine but the code listed here does not appear to work with the plugin code available in the tarball from sourceforge. This code does work with the subversion code. Also, just a nit... Can you PLEASE remove all the tabs from the open_flash_chart.rb file ? Indentation in ruby is by convention supposed to be two normal spaces per indent level. If you give me commit access I'd be happy to clean it up for you :-) Thanks for all your work, this stuff is awesome!

By: Slathered1

Slathered1 — Mon, 04 Feb 2008 21:09:00 +0000

Why delete valid comments? Your pie chart implementation has a bug in the gradient logic. I sent you the fix.

By: charlie

charlie — Mon, 04 Feb 2008 21:09:00 +0000

Slathered1 – I did not delete your comment that I can recall, sorry if I did. I still see the code fix. Are you sure I deleted it, can you tell me what it was about? I am going to look in to your suggestion either way.

By: charlie

charlie — Mon, 04 Feb 2008 21:09:00 +0000

subaqua – can you give me an example of what is different? I will gladly fix it. Also, you have to realize I am a step behind from the zip file release. I get the zip of 1.9.7 release and then update my code accordingly and update my repository and their sourceforge repository. That means that the zip you download from sourceforge is my 1.9.6 version. And yes there is a huge difference there. If you want to go through sourceforge you will have to get it from trunk, not download.