Comments on: Open Flash Chart Plugin for Rails

By: francis sinson

francis sinson — Sun, 19 Aug 2007 23:29:00 +0000

yo, Saw some gotcha's: 1. there's a missing closing " in the self.swf_object method. 2. Add the CGI.escape to the url :) thanks:) /franee

By: charlie

charlie — Sun, 19 Aug 2007 23:29:00 +0000

Franee,
Thank you, great catches – did as you requested, tested and committed.

By: scott

scott — Sun, 19 Aug 2007 23:29:00 +0000

thanks for the great plugin charlie 🙂

By: charlie

charlie — Sun, 19 Aug 2007 23:29:00 +0000

Not a problem Scott, just let me know if you run into any issues, or you can track them here – http://code.google.com/p/rails-open-flash-chart-plugin/issues/listhttp://code.google.com/p/rails-open-flash-chart-plugin/issues/list">http://code.google.com/p/rails-open-flash-chart-plugin/issues/list;

By: scott

scott — Sun, 19 Aug 2007 23:29:00 +0000

I’ve posted two issues and a patch at the google code site.

By: charlie

charlie — Sun, 19 Aug 2007 23:29:00 +0000

Thanks Scott, I will take care of those for you.

By: charlie

charlie — Sun, 19 Aug 2007 23:29:00 +0000

Scott, see if my fixes work for you. I used your fix for the "axis" => "method" issue. I did not use your solution for the x_axis_steps issue, instead I removed nil array elements before joining via compact b/c that would impact the 3d graphing, which I do not personally use either.
Thank you.

By: Moisés

Moisés — Sun, 19 Aug 2007 23:29:00 +0000

Hi, thanks for the plugin. I am new in rails, but i have one questions: Wy not add: class OpenFlashChart attr_accessor( :y_min, :y_max ... to make all the attributes read/write accessible?

By: charlie

charlie — Sun, 19 Aug 2007 23:29:00 +0000

Moisés – Good question. One reason that I did not open up all the attributes in that way is because of documentation. To enable the user to use the variables in this way would require much more documentation. If you look closely, you will see that some of the setter methods do a bit of data manipulation that the user (of the plugin) may not expect. Teethgrinderhttp://teethgrinder.co.uk/open-flash-chart/">Teethgrinder; has already done a great job documenting this project. So, if I keep things simple and provide the same usability, then users of the plugin can easily refer to what he has already provided in terms of examples and documentation. Hope this makes sense.

By: Adrian

Adrian — Sun, 19 Aug 2007 23:29:00 +0000

Multi line example (http://pullmonkey.com/projects/open_flash_chart/multi_line) has a little problem: in controller there is a variable @output and in the view the variable is @graph. Should have the same name